[#566] Add meta-schema.json and test using it. #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpmckinney
reviewed
Nov 3, 2017
standard/schema/meta-schema.json
Outdated
| "anyOf": { "$ref": "#/definitions/schemaArray" }, | ||
| "oneOf": { "$ref": "#/definitions/schemaArray" }, | ||
| "not": { "$ref": "#" }, | ||
| "$ref": { |
There was a problem hiding this comment.
For $ref, draft-06 has:
"$ref": {
"type": "string",
"format": "uri-reference"
},
though we'd use "format": "uri" for draft-04.
There was a problem hiding this comment.
I think the issue here is that internal $ref i.e '#/definitions/Awards' would not pass "uri" validataion. Which I think is why they added the new format.
standard/schema/meta-schema.json
Outdated
| "type": "boolean", | ||
| "default": false | ||
| } | ||
|
|
Add script make_metaschema.py to make meta-schema.json from patch and draft-04. Also add test to make sure this is run.
kindly
force-pushed
the
566-meta-schema
branch
from
dc46a36 to
6e53825
Compare
jpmckinney
reviewed
Nov 9, 2017
| @@ -31,14 +31,15 @@ def object_pairs_hook(pairs): | |||
|
|
|||
|
|
|||
| DRAFT_SCHEMA_PATH = path(__file__).parent / 'json-schema-draft-4.json' | |||
There was a problem hiding this comment.
This constant's value needs to be updated because the file moved in another commit, but if we aren't using the constant anymore, we can just remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #566