Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CKAN Coding Standards #1547

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

CKAN Coding Standards #1547

wants to merge 25 commits into from

Conversation

JVickery-TBS
Copy link
Contributor

No description provided.

- Added change log file.
- Removed dev requirements file.
- Circular import.
- Pyright changes,
- Pyright changes.
- Pyright changes.
- Pyright changes.
- Pyright changes.
- Pyright changes.
- Pyright changes.
- Pyright changes.
@wardi
Copy link
Member

wardi commented Dec 20, 2024

I kept the old migration scripts around as a record of the data schema changes in the past in case we ever need to compare data from backups with newer data. The other deletions should be fine but it's worth mentioning them in the changelog at least.

@JVickery-TBS
Copy link
Contributor Author

I kept the old migration scripts around as a record of the data schema changes in the past in case we ever need to compare data from backups with newer data. The other deletions should be fine but it's worth mentioning them in the changelog at least.

@wardi I will just add a note to the changelogs for the removal of all this stuff. as we are cross training soon, I am trying to slim down all the actual code to operational things. So old migration scripts can just be found in git history if anyone needs them

- Pyright changes.
- Pyright changes.
- Pyright changes.
- Pyright changes.
@JVickery-TBS JVickery-TBS marked this pull request as ready for review January 2, 2025 16:22
@JVickery-TBS JVickery-TBS requested a review from wardi January 2, 2025 16:22
ckanext/canada/cli.py Outdated Show resolved Hide resolved
ckanext/canada/helpers.py Outdated Show resolved Hide resolved
ckanext/canada/helpers.py Outdated Show resolved Hide resolved
ckanext/canada/helpers.py Outdated Show resolved Hide resolved
ckanext/canada/logic.py Outdated Show resolved Hide resolved
ckanext/canada/validators.py Outdated Show resolved Hide resolved
ckanext/canada/view.py Outdated Show resolved Hide resolved
@JVickery-TBS JVickery-TBS changed the base branch from canada-v2.10 to master January 8, 2025 18:43
- Various changes to update code to CKAN and python standards.
- Updated recombinant branch to `master`
@JVickery-TBS JVickery-TBS requested a review from wardi January 17, 2025 20:28
# Conflicts:
#	bin/travis-install
#	ckanext/canada/helpers.py
#	ckanext/canada/plugins.py
#	ckanext/canada/validators.py
### RESOLVED.
- Flae8 fixes.
- Pyright fixes.
- Pyright fixes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants