Skip to content

Commit

Permalink
Remove instrumentation
Browse files Browse the repository at this point in the history
  • Loading branch information
echus committed Jun 2, 2022
1 parent a4ed8f4 commit 18aad46
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions addon/modifiers/vega.ts
Original file line number Diff line number Diff line change
Expand Up @@ -99,16 +99,12 @@ export default class VegaModifier extends Modifier<VegaModifierArgs> {

if (!this._vegaView) {
// Create new Vega.View instance
console.log('before createView');
await this._createView(element, args);

console.log('before populateData');
await this._populateData(args);
} else {
// Update data only
// TODO: Handle changes to config

console.log('update before populateData');
await this._populateData(args);
}
}
Expand All @@ -135,7 +131,6 @@ export default class VegaModifier extends Modifier<VegaModifierArgs> {
viewSpec = args.spec
}

console.log('before Vega.View init');
this._vegaView = new Vega.View(Vega.parse(viewSpec, config), {
renderer: 'svg',
container: element,
Expand All @@ -155,7 +150,6 @@ export default class VegaModifier extends Modifier<VegaModifierArgs> {
args: NamedArgs<VegaModifierArgs>
): Promise<void> {
for (const name of Object.keys(args.data)) {
console.log('_populateData name', name, args.data[name]);
this._vegaView.data(name, args.data[name]);
}

Expand Down

0 comments on commit 18aad46

Please sign in to comment.