Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #512: ENS for addresses #579

Merged
merged 4 commits into from
Jun 20, 2024
Merged

Issue #512: ENS for addresses #579

merged 4 commits into from
Jun 20, 2024

Conversation

jahabeebs
Copy link
Member

closes #512

Description

  • I replaced returnWalletAddress with a new useAddress hook everywhere I could. There were some places (like in AuctionBlock) where I couldn't replace it because we can't call a hook from there and I can't test the auction stuff (I'd have to refactor it to get the address passed in probably)

Some potential issues:

  1. we'll probably get rate limited pretty quickly with our public read only RPC, should we switch it to a paid provider? The requirements said use a public one but if the call fails we'll fall back to just returning the address
  2. the leaderboard has some latency rendering if we're going to check every address for ENS (see video)--should we just return the addresses for it instead?

Screenshots

Testing with hardcoded account value

test ens

Leaderboard (no ENS, either they don't have one or are getting rate limited by the rpc and so it's just returning the user's address)

leaderboard.mov

@jahabeebs jahabeebs requested a review from pi0neerpat June 17, 2024 22:42
@jahabeebs jahabeebs self-assigned this Jun 17, 2024
Copy link

vercel bot commented Jun 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
od-app ✅ Ready (Inspect) Visit Preview Jun 19, 2024 0:47am
od-app-hai ✅ Ready (Inspect) Visit Preview Jun 19, 2024 0:47am
od-app-testnet ✅ Ready (Inspect) Visit Preview Jun 19, 2024 0:47am

Copy link
Member

@pi0neerpat pi0neerpat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Move all RPC urls to src/chains.ts and export them as constants eg RPC_URL_OPTIMISM
  • The Ethereum RPC for Bridge (src/utils/tokens.ts) and ENS features should now be the same
  • Patrick will provide the private Ethereum RPC
  • Remove wallet icon. Move Blockie + Address/ENS to the wallet button
    image

@jahabeebs
Copy link
Member Author

jahabeebs commented Jun 18, 2024

@pi0neerpat

  • Move all RPC urls to src/chains.ts and export them as constants eg RPC_URL_OPTIMISM
  • The Ethereum RPC for Bridge (src/utils/tokens.ts) and ENS features should now be the same
  • Patrick will provide the private Ethereum RPC
  • Remove wallet icon. Move Blockie + Address/ENS to the wallet button
    Will do as part of New wallet component #582 (comment)
  • Added some variables we were missing to .env.example
  • Updated od-app and od-app-testnet in vercel to have the new REACT_APP_RPC_URL_ETHEREUM

@jahabeebs jahabeebs merged commit 0f29a22 into dev Jun 20, 2024
8 checks passed
pi0neerpat added a commit that referenced this pull request Jun 21, 2024
* Fix fuul crashing the app

* lint cleanup

* Bolts page (#521)

* scaffold bolts page

* fix input on mobile

* Fix stroke-width

* setup quest blocks

* cleanup blocks

* Fetching fuul data

* cleanup

* lint

* Marketplace: Data Fetching (#518)

* marketplace data fetching

* fixed

* listings data

* data

* all data

* account flag

* fix array

* fixes

* cleanup (#529)

* add fuul sendPageview

* fix bolts page styles (#531)

* Issue #451. HAI warning Banner  (#516)

* banner for hai user

* prettier

* make height fixed and border-bottom

* height 60

* Issue #510. Marketplace: NFV Listing Card (#527)

* header

* fix id

* add cards component

* basic data and styles

* card right side style

* data we need

* Add Table

Co-authored-by: Iana <[email protected]>

* basic styles

* clean up

* mock data

* change background

* add image column

* cleanup

* cleanup

* hook everything up

* fix svg size

* fix svg size

* data fetchingf

* Add subgraph query

* hooked up with most data

* fix

* fix

* liq data

* got all data

* add dollar size

* add scroll

* scale svg and headers one line

* fix table ids

* mobile fixes

* Update titles

* styling mobile changes

* add filtering, sorting

* svg change

* svg center

* ui tweaks

---------

Co-authored-by: Patrick Gallagher <[email protected]>
Co-authored-by: Iana <[email protected]>
Co-authored-by: jahabeebs <[email protected]>
Co-authored-by: Sero <[email protected]>

* index.html

* cleanup

* Issue #541: Redundant fetchAnalyticsData (#545)

* useAnalyticsData

* more useAnalyticsData refactoring

* Issue #409: Reduce redundant RPC calls (#554)

* remove initgeb, fix unneeded step2 setting, fix invalid bn error

* memoize

* more fixes

* change sidenote color and fweight (#558)

* Feature/bridge (#326)

* util

* chain IDs, and url params

* bridge page

* building form

* bridge stuff

* state management

* set up state for bridge (#355)

* set up state for bridge

* hook up state, clear lint and prettier

* bridge UI (#479)

* bridge UI

* b

* hooked up

* b

* check balance and popup (#495)

* check balance and popup

* done

* fix

* rem

* Fetch Collateral Balances for Bridge table (#513)

* table data

* base

* fixes

* address

* new rpc

* successfully fetch balances for specific chain

---------

Co-authored-by: Patrick Gallagher <[email protected]>

* Issue #503. Bridge: Main interaction component. (#514)

* header basic

* content

* styling

* Update BridgeFundsForm.tsx

* elements width

* cleanup

* change btn width

* prettier

---------

Co-authored-by: Patrick Gallagher <[email protected]>

* Issue #504. Bridge: Table interaction (#540)

* header basic

* content

* styling

* basic style

* hg item, add span and tooltip

* add functionality to table, add bridge details to create and modify vault page

---------

Co-authored-by: Sero <[email protected]>

* Issue #507. Bridge: low gas improvements (#546)

* style

* popup state

* low gas modal closing

* low gas modal

---------

Co-authored-by: Sero <[email protected]>

* debugging

* copy text changes

* fix missing bolts

* fix mainnet/ethereum mismatch, update bolts to be uppercase, fixed type issues

* Update NavLinks.tsx

* Issue # 547 QA Bridge page (#553)

* create vault link to bridge

* modify vault link to bridge

* row style change

* add icons to tokens

* basic tabs

* fix tokens error and style tabs

* tokens, balance, loader

* format balance

* loading balance

* tokens logos update

* cleanup

* add network icons

* rm WETH

* update tokens

* updating balances when switching networks

* no loader if account not connencted

* fo not show undefined balance

* cleanup

* item disabled

* tabs bg and width

* tabs mobile

* btn alighnment

* rm column gap for mobile

* balances as hash map

* take changes from feature/bridge just for one file

* cleanup and fix

* cleanup

* show fixed balance

* fix

* cleaun console log

* text copy

* Get ETH working on polygon

* cleanup

* Final UX changes

---------

Co-authored-by: Patrick Gallagher <[email protected]>

---------

Co-authored-by: Patrick Gallagher <[email protected]>
Co-authored-by: Iana <[email protected]>
Co-authored-by: jahabeebs <[email protected]>

* fix decimals, balance issue (#566)

* fix max debt (#569)

* NFV corner radius #525 (#571)

* console log errors

* fix bug with no chain

* add corners, fix paddings

* border radius bottom container

* width max

* prettier

* Issue # 532 Bolts: token logos to be React components w/dynamic widths and heights (#565)

* util

* chain IDs, and url params

* bridge page

* building form

* bridge stuff

* state management

* set up state for bridge (#355)

* set up state for bridge

* hook up state, clear lint and prettier

* bridge UI (#479)

* bridge UI

* b

* hooked up

* b

* check balance and popup (#495)

* check balance and popup

* done

* fix

* rem

* Fetch Collateral Balances for Bridge table (#513)

* table data

* base

* fixes

* address

* new rpc

* successfully fetch balances for specific chain

---------

Co-authored-by: Patrick Gallagher <[email protected]>

* Issue #503. Bridge: Main interaction component. (#514)

* header basic

* content

* styling

* Update BridgeFundsForm.tsx

* elements width

* cleanup

* change btn width

* prettier

---------

Co-authored-by: Patrick Gallagher <[email protected]>

* Issue #504. Bridge: Table interaction (#540)

* header basic

* content

* styling

* basic style

* hg item, add span and tooltip

* add functionality to table, add bridge details to create and modify vault page

---------

Co-authored-by: Sero <[email protected]>

* Issue #507. Bridge: low gas improvements (#546)

* style

* popup state

* low gas modal closing

* low gas modal

---------

Co-authored-by: Sero <[email protected]>

* debugging

* copy text changes

* create vault link to bridge

* modify vault link to bridge

* row style change

* add icons to tokens

* basic tabs

* fix tokens error and style tabs

* tokens, balance, loader

* format balance

* loading balance

* tokens logos update

* cleanup

* add network icons

* rm WETH

* update tokens

* updating balances when switching networks

* no loader if account not connencted

* fo not show undefined balance

* cleanup

* item disabled

* tabs bg and width

* tabs mobile

* btn alighnment

* fix missing bolts

* fix mainnet/ethereum mismatch, update bolts to be uppercase, fixed type issues

* rm column gap for mobile

* balances as hash map

* take changes from feature/bridge just for one file

* cleanup and fix

* cleanup

* show fixed balance

* fix

* cleaun console log

* od logo as component

* arb token component

* Token Icon component

* new od odg tokens

* use new Token Component

* cleanup

* fix lost token

---------

Co-authored-by: Sero <[email protected]>
Co-authored-by: Patrick Gallagher <[email protected]>
Co-authored-by: jahabeebs <[email protected]>

* Issue #535: Bolts Leaderboard (#570)

* add leaderboard

* leaderboard styling improvements

* more leaderboard changes

* font sizes

* pillars fix

* leaderboard styling

* final leaderboard changes

* cleanup

* remove address

* format

* Issue #538 Bolts- Header box (#568)

* util

* chain IDs, and url params

* bridge page

* building form

* bridge stuff

* state management

* set up state for bridge (#355)

* set up state for bridge

* hook up state, clear lint and prettier

* bridge UI (#479)

* bridge UI

* b

* hooked up

* b

* check balance and popup (#495)

* check balance and popup

* done

* fix

* rem

* Fetch Collateral Balances for Bridge table (#513)

* table data

* base

* fixes

* address

* new rpc

* successfully fetch balances for specific chain

---------

Co-authored-by: Patrick Gallagher <[email protected]>

* Issue #503. Bridge: Main interaction component. (#514)

* header basic

* content

* styling

* Update BridgeFundsForm.tsx

* elements width

* cleanup

* change btn width

* prettier

---------

Co-authored-by: Patrick Gallagher <[email protected]>

* Issue #504. Bridge: Table interaction (#540)

* header basic

* content

* styling

* basic style

* hg item, add span and tooltip

* add functionality to table, add bridge details to create and modify vault page

---------

Co-authored-by: Sero <[email protected]>

* Issue #507. Bridge: low gas improvements (#546)

* style

* popup state

* low gas modal closing

* low gas modal

---------

Co-authored-by: Sero <[email protected]>

* debugging

* copy text changes

* create vault link to bridge

* modify vault link to bridge

* row style change

* add icons to tokens

* basic tabs

* fix tokens error and style tabs

* tokens, balance, loader

* format balance

* loading balance

* tokens logos update

* cleanup

* add network icons

* rm WETH

* update tokens

* updating balances when switching networks

* no loader if account not connencted

* fo not show undefined balance

* cleanup

* item disabled

* tabs bg and width

* tabs mobile

* btn alighnment

* fix missing bolts

* fix mainnet/ethereum mismatch, update bolts to be uppercase, fixed type issues

* rm column gap for mobile

* balances as hash map

* take changes from feature/bridge just for one file

* cleanup and fix

* cleanup

* show fixed balance

* fix

* cleaun console log

* od logo as component

* arb token component

* Token Icon component

* new od odg tokens

* use new Token Component

* cleanup

* fix lost token

* message box

* message box cleanup

* leaderboard component

* rm leaderboard

* more styling

* mobile styling

---------

Co-authored-by: Sero <[email protected]>
Co-authored-by: Patrick Gallagher <[email protected]>
Co-authored-by: jahabeebs <[email protected]>

* Issue #534 Bolts: mobile cleanup #2  (#567)

* util

* chain IDs, and url params

* bridge page

* building form

* bridge stuff

* state management

* set up state for bridge (#355)

* set up state for bridge

* hook up state, clear lint and prettier

* bridge UI (#479)

* bridge UI

* b

* hooked up

* b

* check balance and popup (#495)

* check balance and popup

* done

* fix

* rem

* Fetch Collateral Balances for Bridge table (#513)

* table data

* base

* fixes

* address

* new rpc

* successfully fetch balances for specific chain

---------

Co-authored-by: Patrick Gallagher <[email protected]>

* Issue #503. Bridge: Main interaction component. (#514)

* header basic

* content

* styling

* Update BridgeFundsForm.tsx

* elements width

* cleanup

* change btn width

* prettier

---------

Co-authored-by: Patrick Gallagher <[email protected]>

* Issue #504. Bridge: Table interaction (#540)

* header basic

* content

* styling

* basic style

* hg item, add span and tooltip

* add functionality to table, add bridge details to create and modify vault page

---------

Co-authored-by: Sero <[email protected]>

* Issue #507. Bridge: low gas improvements (#546)

* style

* popup state

* low gas modal closing

* low gas modal

---------

Co-authored-by: Sero <[email protected]>

* debugging

* copy text changes

* create vault link to bridge

* modify vault link to bridge

* row style change

* add icons to tokens

* basic tabs

* fix tokens error and style tabs

* tokens, balance, loader

* format balance

* loading balance

* tokens logos update

* cleanup

* add network icons

* rm WETH

* update tokens

* updating balances when switching networks

* no loader if account not connencted

* fo not show undefined balance

* cleanup

* item disabled

* tabs bg and width

* tabs mobile

* btn alighnment

* fix missing bolts

* fix mainnet/ethereum mismatch, update bolts to be uppercase, fixed type issues

* rm column gap for mobile

* balances as hash map

* take changes from feature/bridge just for one file

* cleanup and fix

* cleanup

* show fixed balance

* fix

* cleaun console log

* od logo as component

* arb token component

* Token Icon component

* new od odg tokens

* use new Token Component

* cleanup

* fix lost token

* quest block mobile clean up

* clean up

* prettier

* group tokens icons

* change tokens width

* change layout

* change tokens in popup

* update tokens on side menu

* prettier

* lint

* icons inline

* return wallet icon

* fix alignment

* inline tokens with text

* align wallet popup

* clean up popups

* align popup lower

* add max width for container

---------

Co-authored-by: Sero <[email protected]>
Co-authored-by: Patrick Gallagher <[email protected]>
Co-authored-by: jahabeebs <[email protected]>

* fix view as another wallet (#573)

* Issue #548: QA: Fuul SDK (#577)

* fuul logic

* no type coercion

* Remove unused images (#576)

* rm imgs a-g

* rm rest imgs

* rm some preload images

* Issue 551. QA: Mobile side menu (#575)

* rm stepper for mobile

* move connect wallet btn

* clean account balange arrangement

* put info to the top

* fix right popup

* DollarValueInner component

* clean up component

* cleanup

* lint fix

* cleanup

* Issue #497. NFV owner bug. (#515)

* use safe account address

* fix nfv owner logic

* ahow owner address

* create function get owner address

* cancel prev logic

---------

Co-authored-by: jahabeebs <[email protected]>

* update sdk to 1.7.3-rc.1

* Bump braces from 3.0.2 to 3.0.3 (#584)

Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3.
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md)
- [Commits](micromatch/braces@3.0.2...3.0.3)

---
updated-dependencies:
- dependency-name: braces
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Issue #562: Bolts: Display per-quest points  (#572)

* points per quest

* local testing

* Add conversion ids

* bolts amount formatting

* highlight rows

* cleanup

* use production bot domain

* remove localhost connect-src

* add multipliers section

* lint

---------

Co-authored-by: Patrick Gallagher <[email protected]>

* Issue #512: ENS for addresses (#579)

* useAddress hook

* isMounted issue

* update rpcs to be constants, add to env example

* fix in right place

* v1.7.2

* staging fixes (#586)

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Sero <[email protected]>
Co-authored-by: Jacob Habib <[email protected]>
Co-authored-by: Iana <[email protected]>
Co-authored-by: Iana <[email protected]>
Co-authored-by: jahabeebs <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@pi0neerpat pi0neerpat deleted the feature/512-ens-for-addresses branch August 5, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENS for addresses
2 participants