Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fullfilment #37

Merged
merged 16 commits into from
Jun 17, 2024
Merged

Add fullfilment #37

merged 16 commits into from
Jun 17, 2024

Conversation

MrDeadCe11
Copy link
Member

closes #36

@MrDeadCe11 MrDeadCe11 requested a review from pi0neerpat June 13, 2024 06:33
@MrDeadCe11 MrDeadCe11 self-assigned this Jun 13, 2024
pi0neerpat
pi0neerpat requested changes Jun 14, 2024
View reviewed changes
Copy link
Member

@pi0neerpat pi0neerpat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notes from today's call

  • Fix deployment when missing Encoding_Helper_Sepolia
  • Wallet 1 should be listing
  • Changes command to “fulfill”

@MrDeadCe11 MrDeadCe11 marked this pull request as ready for review June 17, 2024 14:24
@MrDeadCe11 MrDeadCe11 merged commit 760b523 into main Jun 17, 2024
3 of 4 checks passed
@MrDeadCe11 MrDeadCe11 deleted the add-fullfilment branch June 17, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0neerpat pi0neerpat pi0neerpat approved these changes

Assignees

@MrDeadCe11 MrDeadCe11

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fullfill seaport order with sip15zone, zonehash and extradata
2 participants
@MrDeadCe11 @pi0neerpat