-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calibration run 2023/2024 #45
base: form_energy_storage_dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR @virio-andreyana ! I have made a few comments in the code. As we discussed, I have in mind a scaling problem with the generated graphs. I can't suggest a source for the bug based on the code in the PR.
# 0.63 * 0.6 = 0.378 | ||
electricity: | ||
max_hours: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it makes sense to include this in the scenario
config/scenarios.form.yaml
Outdated
onwind: | ||
cutout: europe-2023-sarah3-era5 | ||
#correction_factor: 0.93 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correction factor is used for onwind in PyPSA-Ariadne
district_heating: | ||
progress: | ||
2023: 0.15 #Rough estimate. 70M/448M population uses district heating https://iifiir.org/en/news/state-of-play-of-district-heating-and-cooling-in-europe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be reduced a bit, using PyPSA-ariadne
@@ -58,23 +61,39 @@ | |||
colors["Offshore Wind"] = colors["Offshore Wind (AC)"] | |||
colors["Gas"] = colors["Combined-Cycle Gas"] | |||
colors["Hydro"] = colors["Reservoir & Dam"] | |||
colors["geothermal"] = '#ba91b1' | |||
colors["biomass"] = '#baa741' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be better to have them in the configuration file
@@ -2170,7 +2170,7 @@ def add_fuel_cell_cars(n, p_set, fuel_cell_share, temperature): | |||
suffix=" land transport fuel cell", | |||
bus=spatial.h2.nodes, | |||
carrier="land transport fuel cell", | |||
p_set=profile, | |||
p_set=profile.loc[n.snapshots], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sometimes the snapshots and the profile data are not aligned. If you looked at def add_EVs()
they did this snapshot filter already, so its just applying to other transport technologies
rules/validate.smk
Outdated
@@ -11,6 +11,16 @@ CROSS_BORDER_PLOTS = ["trade_time_series", "cross_border_bar"] | |||
PRICES_PLOTS = ["price_bar", "price_line"] | |||
|
|||
|
|||
if config["foresight"] == "myopic" or config["foresight"] == "overnight": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if config["foresight"] == "myopic" or config["foresight"] == "overnight": | |
if config["foresight"] in ["myopic", "overnight"]: |
@@ -207,9 +207,9 @@ def approximate_missing_eia_stats(eia_stats, runoff_fn, countries): | |||
norm_year = config_hydro.get("eia_norm_year") | |||
missing_years = contained_years.difference(eia_stats.index) | |||
if norm_year: | |||
eia_stats.loc[contained_years] = eia_stats.loc[norm_year] | |||
eia_stats.loc[contained_years[0]] = eia_stats.loc[norm_year] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally this should not have to be done. but because 2023 is not within the existing EIA hydro statistics, it keeps getting error unless I do this.
Drawbacks: Not being able to model longer than 1 year. Suggestion is very appreciated!
config/scenarios.form.yaml
Outdated
H2_retrofit: true | ||
|
||
main-calibration-run: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would expect more changes in term of techs : no dac, no DSM for EV, no V2G, no TES, no SMR CC
…SO-E load data in electricity demand preparations, missing cost years are replaced with the closest available year
…e_dev Update calibrated run branch with the recent addition in form_energy_storage_dev
Changes proposed in this Pull Request
The validation automatically compares historical data and the optimized model of:
The challenge now is, can PyPSA-EUR run for the year 2023?