Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[website] Rename the size column to instance, fix size filters #77

Merged
merged 3 commits into from
Dec 10, 2024
Merged

[website] Rename the size column to instance, fix size filters #77

merged 3 commits into from
Dec 10, 2024

Conversation

jacek-oet
Copy link
Collaborator

@jacek-oet jacek-oet commented Dec 10, 2024 •
edited
Loading

image

image
image
image
image
image

siddharth-krishna
siddharth-krishna approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@siddharth-krishna siddharth-krishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Jacek. One more quick request: can you add the units e.g. 3 nodes and 24h to the values in the Sizes table in the Benchmark details page? This is not urgent, please fix the size filter first. Thanks!

@siddharth-krishna siddharth-krishna changed the title Renaming the size column to instance [website] Rename the size column to instance, fix size filters Dec 10, 2024
@siddharth-krishna siddharth-krishna merged commit 8fd229e into main Dec 10, 2024
1 check passed
@siddharth-krishna siddharth-krishna deleted the renaming-the-size-column-to-instance- branch December 10, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddharth-krishna siddharth-krishna siddharth-krishna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacek-oet @siddharth-krishna