Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add voltage conversion equations to Neuropixels DataFrame docs #367

Merged
merged 4 commits into from
Feb 18, 2025

Conversation

jonnew
Copy link
Member

@jonnew jonnew commented Nov 5, 2024

@jonnew jonnew requested a review from jsiegle November 7, 2024 14:30
@cjsha
Copy link
Member

cjsha commented Dec 9, 2024

hey y'all. Just commenting to bring attention to this PR for the purpose of accurately populating this page:
https://open-ephys.github.io/bonsai-onix1-docs/articles/getting-started/reference.html
Thanks

- Also fix typos:
 - electophysiology -> electrophysiology
  - "is a amplified" -> "is an amplified"
@cjsha
Copy link
Member

cjsha commented Dec 18, 2024

This is how my edits render:
image
image

@jonnew
Copy link
Member Author

jonnew commented Jan 2, 2025

I think this is ready to go. Ill merge when approved by @jsiegle

@cjsha
Copy link
Member

cjsha commented Jan 6, 2025

This could go in 0.4.3

@jonnew
Copy link
Member Author

jonnew commented Feb 10, 2025

@bparks13 when you have a moment, can you let me know what is going on with the checks for this PR? Two of them appear to be stuck. As soon as that's resolved we should merge this.

@bparks13 bparks13 merged commit 1f15122 into main Feb 18, 2025
8 checks passed
@bparks13 bparks13 deleted the issue-358 branch February 18, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sample to voltage conversion equations to neuropixels data frames
4 participants