Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide PolledBno055 properties when embedded in a headstage #369

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bparks13
Copy link
Member

@bparks13 bparks13 commented Nov 8, 2024

Utilize the same type converter from the main library to hide AxisMap and AxisSign from the property grid when opened in dialogs. This is accomplished by creating an internal class that is only used to wrap the ConfigurePolledBno055 class in a public get / set so that it acts like an expandable object.

These hidden properties are editable from the ConfigurePolledBno055 operator, since right now I don't know how to distinguish a truly standalone PolledBno055 from one that is part of a headstage, unless it is called from the headstage editor (i.e., ConfigureNeuropixelsV1eHeadstage).

Fixes #314

- Utilize the same type converter from the main library to hide `AxisMap` and `AxisSign` from the property grid when opened in dialogs
@bparks13 bparks13 added this to the 0.4.1 milestone Nov 8, 2024
@bparks13 bparks13 requested a review from jonnew November 8, 2024 22:04
@bparks13 bparks13 self-assigned this Nov 8, 2024
@jonnew
Copy link
Member

jonnew commented Nov 13, 2024

As of right now, I'm very hesitant to merge this. This is a pretty hard issue, it turns out, but the precedent that this solution sets is not good. It requires more logic being created on the design side of things than was required to hide the property in the base library. I think we need to explore other options.

@jonnew jonnew modified the milestones: 0.4.1, 0.5.0 Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide PolledBno055 properties in GUI dialogs
2 participants