Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add microvolt conversion equations #414

Merged
merged 4 commits into from
Feb 26, 2025
Merged

Add microvolt conversion equations #414

merged 4 commits into from
Feb 26, 2025

Conversation

cjsha
Copy link
Member

@cjsha cjsha commented Feb 21, 2025

This needed to be done for every ephys device that provides raw ADC values and AnalogInput.

I noticed different headstages provided different information, so I also made an attempt to standardize the description for ephys data as much as I could.

Here's an image for your reference
image

…C values

I noticed different headstages provided different information, so I also made an attempt to standardize the description for ephys data as much as I could.
@cjsha cjsha added this to the 0.4.5 milestone Feb 21, 2025
@cjsha cjsha requested review from jonnew and bparks13 February 21, 2025 18:56
Change ushort to short for analoginputdata
@cjsha
Copy link
Member Author

cjsha commented Feb 21, 2025

The same page looks like this now after talking to jonnew:
image

- Corrected conversions and clarified wording
Copy link
Member

@jonnew jonnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've committed my edits to the PR. Please perform final proofread looking for spelling, grammar, and formatting issues only.

Copy link
Member

@jonnew jonnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you.

@jonnew jonnew merged commit a66bd1c into main Feb 26, 2025
8 checks passed
@jonnew jonnew deleted the issue-405 branch February 26, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure voltage conversion parameters are available in the XML comments
2 participants