Extend usability of oni-repl #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
aacuevas
commented
Feb 18, 2025
aacuevas
commented
- Reloads the device table when issuing a reset command
- Fixes oni-repl: reset command does not refresh the device table #31
- Adds register access mode for managed and i2c-raw registers, to ease usability when testing devices featuring those
- Fixes oni-repl: Add commands for managed and i2c-raw registers #32
- Add on to the issue under review which appears to work well - There is a race condition of some sort that is present in the `p` action
jonnew
reviewed
Feb 24, 2025
There was a problem hiding this comment.
Overall seems good. I added some stuff to fix the reset and pause actions. The reset action seems to work well now. The pause action may have some race condition hidden in it. Sometimes unpausing causes a segfault that appears to be due to some left over, unaligned data somehow getting into the read stream. That or the internal, referenced coutned buffer is somehow not being reset correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.