Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adapt telemetry setup error handling #1315

Merged
merged 5 commits into from
May 27, 2024

use IMetricsRecorder consistently and fall back to Noop

155bf59
Select commit
Loading
Failed to load commit list.
Merged

chore: adapt telemetry setup error handling #1315

use IMetricsRecorder consistently and fall back to Noop
155bf59
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 27, 2024 in 0s

78.71% (+5.02%) compared to 1c530ab

View this Pull Request on Codecov

78.71% (+5.02%) compared to 1c530ab

Details

Codecov Report

Attention: Patch coverage is 90.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 78.71%. Comparing base (1c530ab) to head (155bf59).
Report is 65 commits behind head on main.

Files Patch % Lines
core/pkg/telemetry/metrics.go 87.50% 1 Missing ⚠️
...agd/pkg/service/flag-evaluation/connect_service.go 87.50% 1 Missing ⚠️
...agd/pkg/service/middleware/metrics/http_metrics.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1315      +/-   ##
==========================================
+ Coverage   73.69%   78.71%   +5.02%     
==========================================
  Files          32       36       +4     
  Lines        3140     2824     -316     
==========================================
- Hits         2314     2223      -91     
+ Misses        717      466     -251     
- Partials      109      135      +26

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov