chore: fix unit tests and ensure their execution #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for polite-licorice-3db33c canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1316 +/- ##
==========================================
+ Coverage 73.69% 78.61% +4.92%
==========================================
Files 32 36 +4
Lines 3140 2806 -334
==========================================
- Hits 2314 2206 -108
+ Misses 717 465 -252
- Partials 109 135 +26 ☔ View full report in Codecov by Sentry. |
dosubot
bot
added
the
size:S
thisthat
approved these changes
May 22, 2024
Kavindu-Dodan
approved these changes
May 23, 2024
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Kavindu-Dodan
force-pushed
the
chore/fix-unit-tests
branch
from
8bff98a
to
77f56fc
Compare
Merged
toddbaert
pushed a commit
that referenced
this pull request
Jun 6, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>flagd: 0.10.3</summary> ## [0.10.3](flagd/v0.10.2...flagd/v0.10.3) (2024-06-06) ### 🧹 Chore * adapt telemetry setup error handling ([#1315](#1315)) ([20bcb78](20bcb78)) * fix unit tests and ensure their execution ([#1316](#1316)) ([25041c0](25041c0)) </details> <details><summary>core: 0.9.3</summary> ## [0.9.3](core/v0.9.2...core/v0.9.3) (2024-06-06) ### 🐛 Bug Fixes * fixes store merge when selector is used ([#1322](#1322)) ([ed5025d](ed5025d)) ### 🧹 Chore * adapt telemetry setup error handling ([#1315](#1315)) ([20bcb78](20bcb78)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the tests locally I noticed that one of them was failing in the
flagdsubmodule of the repo. After looking into this, I noticed that the unit tests are only executed for thecorepackage in the PR checks - this is fixed with this PR