fix: RejectedExecutionException on shutdown (#652)

Signed-off-by: Todd Baert <[email protected]>
open-feature · Oct 12, 2023 · 8c595b0 · 8c595b0
1 parent b77e44e
commit 8c595b0
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 19 deletions.
diff --git a/src/main/java/dev/openfeature/sdk/ProviderRepository.java b/src/main/java/dev/openfeature/sdk/ProviderRepository.java
@@ -171,16 +171,6 @@ public void shutdown() {
                 .concat(Stream.of(this.defaultProvider.get()), this.providers.values().stream())
                 .distinct()
                 .forEach(this::shutdownProvider);
-        setProvider(new NoOpProvider(),
-                (FeatureProvider fp) -> {
-                },
-                (FeatureProvider fp) -> {
-                },
-                (FeatureProvider fp) -> {
-                },
-                (FeatureProvider fp,
-                        String message) -> {
-                }, false);
         this.providers.clear();
         taskExecutor.shutdown();
     }

diff --git a/src/test/java/dev/openfeature/sdk/ProviderRepositoryTest.java b/src/test/java/dev/openfeature/sdk/ProviderRepositoryTest.java
@@ -296,15 +296,6 @@ void shouldShutdownAllFeatureProvidersOnShutdown() {
         setFeatureProvider(ANOTHER_CLIENT_NAME, featureProvider2);
 
         providerRepository.shutdown();
-
-        await()
-                .pollDelay(Duration.ofMillis(1))
-                .atMost(Duration.ofSeconds(TIMEOUT))
-                .untilAsserted(() -> {
-                    assertThat(providerRepository.getProvider()).isInstanceOf(NoOpProvider.class);
-                    assertThat(providerRepository.getProvider(CLIENT_NAME)).isInstanceOf(NoOpProvider.class);
-                    assertThat(providerRepository.getProvider(ANOTHER_CLIENT_NAME)).isInstanceOf(NoOpProvider.class);
-                });
         verify(featureProvider1, timeout(TIMEOUT)).shutdown();
         verify(featureProvider2, timeout(TIMEOUT)).shutdown();
     }