Add defaults for try_convert

open-gpdb · Nov 27, 2024 · 1301ed7 · 1301ed7
1 parent 122d627
commit 1301ed7
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/contrib/try_convert/try_convert.c b/contrib/try_convert/try_convert.c
@@ -97,8 +97,6 @@ try_convert_via_io(Datum value, Oid sourceTypeId, Oid targetTypeId, bool *is_nul
 }
 
 
-// NO NULL INPUTS!!!!
-
 Datum
 try_convert(PG_FUNCTION_ARGS)
 {
@@ -130,7 +128,11 @@ try_convert(PG_FUNCTION_ARGS)
         is_null = fcinfo->isnull;
         res = try_convert_via_io(value, sourceTypeId, targetTypeId, &is_null);
     }
-
-    fcinfo->isnull = is_null;
+
+    if (is_null) {
+        fcinfo->isnull = fcinfo->argnull[1];
+        res = fcinfo->arg[1];
+    }
+
     return res;
 }