Add new OID alias type regrole #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new type has the scope of whole the database cluster so it doesn't behave the same as the existing OID alias types which have database scope, concerning object dependency. To avoid confusion constants of the new type are prohibited from appearing where dependencies are made involving it. Also, add a note to the docs about possible MVCC violation and optimization issues, which are general over the all reg* types. Kyotaro Horiguchi -- OPENGPDB additions. I have omitted catalog changes provides within this commit for ABI compat sake. This is not disallows use of them. One, if need, could use them with help of extension. Kirill Reshke
reshke
added a commit
that referenced
this pull request
Nov 14, 2024
The new type has the scope of whole the database cluster so it doesn't behave the same as the existing OID alias types which have database scope, concerning object dependency. To avoid confusion constants of the new type are prohibited from appearing where dependencies are made involving it. Also, add a note to the docs about possible MVCC violation and optimization issues, which are general over the all reg* types. Kyotaro Horiguchi -- OPENGPDB additions. I have omitted catalog changes provides within this commit for ABI compat sake. This is not disallows use of them. One, if need, could use them with help of extension. Kirill Reshke Co-authored-by: Andrew Dunstan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new type has the scope of whole the database cluster so it doesn't behave the same as the existing OID alias types which have database scope,
concerning object dependency. To avoid confusion constants of the new type are prohibited from appearing where dependencies are made involving it.
Also, add a note to the docs about possible MVCC violation and optimization issues, which are general over the all reg* types.
Kyotaro Horiguchi
-- OPENGPDB additions.
I have omitted catalog changes provides within this commit for ABI compat sake. This is not disallows use of them. One, if need, could use them with help of extension.
Kirill Reshke
Here are some reminders before you submit the pull request
make installcheck