Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable copy for demo cluster #32

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

leborchuk
Copy link
Contributor

@leborchuk leborchuk commented Jan 28, 2025

We support special cloud options

		ycmdb.yc_allow_copy_to_program=on
		ycmdb.yc_allow_copy_from_file=on
		ycmdb.yc_allow_copy_to_file=on

They are disabled by default but used in installcheck test suite. Let's enable them for the demo-cluster, which is used in our tests, and on-prem installations can also use them.

Fix test "copy" and maybe some others, not sure wich of them, lets start with test "copy"

Here are some reminders before you submit the pull request

  • Add tests for the change
  • Document changes
  • Communicate in the mailing list if needed
  • Pass make installcheck
  • Review a PR in return to support the community

@@ -24,6 +24,10 @@ ifeq ($(WITH_MIRRORS), )
WITH_MIRRORS = true
endif

ifeq ($(ENABLE_COPY), )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this how it should be?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, enabled here by default

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then why we use ifeq? Maybe just ENABLE_COPY = true

Copy link
Contributor

@robozmey robozmey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes tests:

  • float8
  • copy
  • and some more (at least 5)

@reshke reshke merged commit e8d6400 into open-gpdb:OPENGPDB_STABLE Jan 28, 2025
1 of 2 checks passed
reshke pushed a commit that referenced this pull request Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants