Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python API: display request ID in more warning messages #1368

Merged
merged 1 commit into from
Mar 6, 2018

Conversation

fvennetier
Copy link
Member

Relates to #1346

@codecov-io
Copy link

Codecov Report

Merging #1368 into 4.1.x will increase coverage by 0.43%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff            @@
##            4.1.x   #1368      +/-   ##
=========================================
+ Coverage   76.27%   76.7%   +0.43%     
=========================================
  Files         297     297              
  Lines       55189   55193       +4     
  Branches     6726    6720       -6     
=========================================
+ Hits        42093   42334     +241     
+ Misses      12714   12687      -27     
+ Partials      382     172     -210
Impacted Files Coverage Δ
oio/api/io.py 81.41% <75%> (+0.24%) ⬆️
proxy/reply.c 74.41% <0%> (-6.98%) ⬇️
meta2v2/meta2_utils_json_in.c 32.19% <0%> (-4.11%) ⬇️
meta2v2/meta2_utils_json_out.c 95.55% <0%> (-3.34%) ⬇️
meta1v2/meta1_server.c 68.13% <0%> (-2.2%) ⬇️
core/proxy.c 81.5% <0%> (-2.16%) ⬇️
meta1v2/meta1_remote.c 72.65% <0%> (-1.57%) ⬇️
proxy/cs_actions.c 90.16% <0%> (-1.23%) ⬇️
metautils/lib/utils_m1url.c 94.44% <0%> (-1.12%) ⬇️
core/cs.c 80.8% <0%> (-0.9%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22bbfc7...76474bf. Read the comment docs.

@fvennetier fvennetier changed the title Python API: improve request ID usage in ChunkReader Python API: display request ID in more warning messages Feb 23, 2018
@fvennetier fvennetier requested review from AymericDu and removed request for jfsmig and kamel-rahim March 6, 2018 15:48
@fvennetier fvennetier merged commit 4e46dc0 into open-io:4.1.x Mar 6, 2018
@fvennetier fvennetier deleted the improve-request-id-usage branch March 6, 2018 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants