Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer request ID in chunk events #1488

Merged
merged 1 commit into from
Jun 11, 2018

Conversation

fvennetier
Copy link
Member

Transfer request ID in chunk events.

  • Rawx forwards incoming request ID to outgoing events
  • Event-agent uses this request ID when indexing chunks in rdir
  • oio-blob-indexer identifies itself with a custom request ID header

Relates to #1346

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • oio-event-agent
  • oio-blob-indexer
  • rawx
SDS VERSION
openio 4.1.25.dev6
ADDITIONAL INFORMATION

Before:

Jun 07 17:32:00.893062 linux-cgzg OIO,NS,event-agent,1[39916]: 39916 7FCB35CBA370 log WARNING chunk delete failed: '<urllib3.connection.HTTPConnection object at 0x7fcb35639d50>: Failed to establish a new connection: [Errno 111] ECONNREFUSED'

After:

Jun 07 17:32:00.893062 linux-cgzg OIO,NS,event-agent,1[39916]: 39916 7FCB35CBA370 log WARNING chunk delete failed: ('reqid=9BEC2A0DFCDC2D809092FA49FE2EC374, host=127.0.0.1:6023', '<urllib3.connection.HTTPConnection object at 0x7fcb35639d50>: Failed to establish a new connection: [Errno 111] ECONNREFUSED')

- Rawx forwards incoming request ID to outgoing events
- Event-agent uses this request ID when indexing chunks in rdir

Relates to open-io#1346
@codecov-io
Copy link

Codecov Report

Merging #1488 into 4.1.x will increase coverage by 3.93%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##            4.1.x    #1488      +/-   ##
==========================================
+ Coverage   73.92%   77.85%   +3.93%     
==========================================
  Files         311      311              
  Lines       58359    58372      +13     
  Branches     6857     6852       -5     
==========================================
+ Hits        43142    45448    +2306     
+ Misses      15213    12708    -2505     
- Partials        4      216     +212
Impacted Files Coverage Δ
rawx-apache2/src/rawx_internals.c 77.61% <100%> (+0.68%) ⬆️
rawx-apache2/src/rawx_event.c 57.77% <100%> (+4.44%) ⬆️
events/oio_events_queue.c 81.44% <100%> (+23.83%) ⬆️
oio/blob/indexer.py 76.92% <100%> (+0.25%) ⬆️
proxy/transport_http.c 86.33% <100%> (ø) ⬆️
oio/event/evob.py 57.77% <50%> (+0.95%) ⬆️
oio/rdir/client.py 68.44% <57.69%> (+0.57%) ⬆️
proxy/cache_actions.c 60% <0%> (-9.15%) ⬇️
proxy/dir_actions.c 68.88% <0%> (-7.94%) ⬇️
proxy/m2_actions.c 78.75% <0%> (-7.48%) ⬇️
... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb83648...536e500. Read the comment docs.

@fvennetier fvennetier merged commit 9701cbc into open-io:4.1.x Jun 11, 2018
@fvennetier fvennetier deleted the more-request-id branch June 11, 2018 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants