resources: smoother search (fixes #5226) #5230
Open
+28
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deeppp15
requested changes
Feb 7, 2025
| } | ||
| } | ||
| return startsWithQuery + containsQuery | ||
| } | ||
|
|
There was a problem hiding this comment.
Hi @pavi38 , It seems the search in OurCourses, is only working for courses which the user has not registered. Please checkout the below video where I search Unit 3 when its added to my courses v/s when its not added
our.courses.search.works.only.in.non.registered.courses.webm
There was a problem hiding this comment.
hi @deeppp15 it been like this before this pull request, I thought it was a feature. Should I change it?
There was a problem hiding this comment.
@pavi38 could you make it search everything displayed on the list even the ones with the tag added to mycourses as this is the desired behaviour for the search
deeppp15
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5226
this pull request fixes the search both in courses and library
Screen.Recording.2025-02-07.at.1.58.57.PM.mov
Screen.Recording.2025-02-07.at.1.58.16.PM.mov