-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing Takeout App drawer #68
Conversation
Looks good now. Any particular reason for the spacing change? Try https://github.com/ole-vi/takeout/pull/68/files#diff-7b0d5ad0ef3493d2315751c168dc5e7fR105 @leomaxi Do you have any comment about the code climate issue? Is this already a good way? |
@xyb994 The spacing is different only because of editing the code a lot. I am still trying to figure out if there is a particular method that could make the code more efficient. I will also try the reformatting option with that :) |
@aakarnik Ok, thanks for the update, I add the label "in progress". You can also let the team to take a look at this |
@xyb994 @leomaxi Reformatting the code did not work with code climate. I found a similar issue posted in the code climate organization - as of 2017, they didn't seem to have a solution for that. |
No worries @aakarnik |
Fixes #43
I was able to fix the color of the icons in the drawer. Will make changes if I find a better way to do it :)
I will also work on what can be added to the header section of the drawer.
Screenshot - 5.5in portrait