Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Takeout App drawer #68

Merged
merged 7 commits into from
Jun 18, 2018
Merged

Fixing Takeout App drawer #68

merged 7 commits into from
Jun 18, 2018

Conversation

anuya-karnik
Copy link
Member

@anuya-karnik anuya-karnik commented Jun 11, 2018

Fixes #43

I was able to fix the color of the icons in the drawer. Will make changes if I find a better way to do it :)
I will also work on what can be added to the header section of the drawer.

Screenshot - 5.5in portrait

@xyb994 xyb994 added the review label Jun 11, 2018
@xyb994
Copy link
Member

xyb994 commented Jun 13, 2018

Looks good now. Any particular reason for the spacing change? Try Control + Alt + L to reformat the code.

https://github.com/ole-vi/takeout/pull/68/files#diff-7b0d5ad0ef3493d2315751c168dc5e7fR105
https://github.com/ole-vi/takeout/pull/68/files#diff-7b0d5ad0ef3493d2315751c168dc5e7fR47
https://github.com/ole-vi/takeout/pull/68/files#diff-7b0d5ad0ef3493d2315751c168dc5e7fR162

@leomaxi Do you have any comment about the code climate issue? Is this already a good way?

@anuya-karnik
Copy link
Member Author

@xyb994 The spacing is different only because of editing the code a lot. I am still trying to figure out if there is a particular method that could make the code more efficient. I will also try the reformatting option with that :)

@xyb994 xyb994 added in progress and removed review labels Jun 13, 2018
@xyb994
Copy link
Member

xyb994 commented Jun 13, 2018

@aakarnik Ok, thanks for the update, I add the label "in progress". You can also let the team to take a look at this

@anuya-karnik
Copy link
Member Author

@xyb994 @leomaxi Reformatting the code did not work with code climate. I found a similar issue posted in the code climate organization - as of 2017, they didn't seem to have a solution for that.

@leomaxi
Copy link
Member

leomaxi commented Jun 14, 2018

No worries @aakarnik

@leomaxi leomaxi merged commit 268120d into master Jun 18, 2018
@xyb994 xyb994 deleted the better-drawer branch June 18, 2018 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

better drawer
3 participants