Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#10192 - Validate both include and excludes filters #16826

Merged
merged 1 commit into from
Jun 28, 2024
Merged

#10192 - Validate both include and excludes filters #16826

merged 1 commit into from
Jun 28, 2024

Conversation

pmbrull
Copy link
Collaborator

@pmbrull pmbrull commented Jun 27, 2024

Describe your changes:

Fixes #10192

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@pmbrull pmbrull requested a review from a team as a code owner June 27, 2024 15:28
@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Jun 27, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@pmbrull pmbrull merged commit 166d9ef into open-metadata:main Jun 28, 2024
15 checks passed
@pmbrull pmbrull deleted the issue-10192 branch June 28, 2024 05:11
harshach pushed a commit that referenced this pull request Jun 30, 2024
@pmbrull @harshach
#10192 - Validate both include and excludes filters (#16826)
ae3b1f4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayush-shah ayush-shah ayush-shah approved these changes

Assignees
No one assigned
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement support for include AND exclude filters
2 participants
@pmbrull @ayush-shah