Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug in building valid dataloader #285

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Taited
Copy link
Contributor

@Taited Taited commented Apr 26, 2022

When I ran my training scripts on your newest commit [2a79796], there is a type error in mmgen/apis/train.py :

build_dataloader() got multiple values for keyword argument 'dist'
  File "~/mmgeneration/mmgen/apis/train.py", line 182, in train_model
    val_dataloader = build_dataloader(
  File "~/mmgeneration/tools/train.py", line 217, in main
    train_model(
  File "~/mmgeneration/tools/train.py", line 228, in <module>
    main()

Seems there are redundant dist=distributed and I removed it.

@plyfager plyfager self-requested a review April 29, 2022 08:13
@zengyh1900 zengyh1900 added kind/bug something isn't working awaiting response priority/P0 highest priority labels Oct 12, 2022
@zengyh1900
Copy link
Collaborator

Please help to improve this pull request so that it can be merged @plyfager

LeoXing1996 pushed a commit to LeoXing1996/mmgeneration that referenced this pull request Oct 27, 2022
Co-authored-by: liyinshuo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug something isn't working priority/P0 highest priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants