Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VisualizationHook: check channels before bgr2rgb #495

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

zeakey
Copy link
Contributor

@zeakey zeakey commented Feb 10, 2023

bgr2rgb conversion in VisualizationHook results in CUDA error for single channel images. I added a channels==3 check for protection.

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Base: 74.81% // Head: 74.81% // No change to project coverage 👍

Coverage data is based on head (2eb52f5) compared to base (8d0925c).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head 2eb52f5 differs from pull request most recent head 4383b6b. Consider uploading reports for the commit 4383b6b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #495   +/-   ##
=======================================
  Coverage   74.81%   74.81%           
=======================================
  Files         145      145           
  Lines       11015    11015           
  Branches     2097     2097           
=======================================
  Hits         8241     8241           
  Misses       2233     2233           
  Partials      541      541           
Flag Coverage Δ
unittests 74.81% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmgen/core/hooks/visualization.py 91.17% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant