Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support RBox CopyPaste #877

Open
wants to merge 4 commits into
base: dev-1.x
Choose a base branch
from

Conversation

nijkah
Copy link
Contributor

@nijkah nijkah commented Jun 14, 2023

Motivation

Support CopyPaste when the mask is not available.
This feature is available after the PR open-mmlab/mmdetection#10509 on MMDetection is merged.

Examples
image
image

Modification

There was a bug in mask to rbox.
Since np.nonzero returns (ys, xs), it should be converted to find contours.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. The documentation has been modified accordingly, like docstring or example tutorials.

@nijkah nijkah changed the title [WIP][Feature] Support RBox CopyPaste [Feature] Support RBox CopyPaste Jun 14, 2023
@nijkah nijkah marked this pull request as ready for review June 14, 2023 16:37
@zytx121
Copy link
Collaborator

zytx121 commented Jun 17, 2023

@nijkah Nice work! I will wait for the PR open-mmlab/mmdetection#10509 on MMDetection.

@nijkah
Copy link
Contributor Author

nijkah commented Jun 21, 2023

Hi, @zytx121. Since the PR open-mmlab/mmdetection#10509 is merged, check this PR, please. :)
Tell me if you think I have to add UT for this PR. :)

@nijkah
Copy link
Contributor Author

nijkah commented Aug 17, 2023

Hi @zytx121 , Can I ask you to check this? :)

@dou3516
Copy link

dou3516 commented Nov 7, 2023

Hi, @nijkah , How to use this CopyPaste in mmrotate? Thanks~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants