Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding cel for allow-privilege-escalation #503

Merged
merged 11 commits into from
Jul 8, 2024

Conversation

maxsmythe
Copy link
Contributor

@maxsmythe maxsmythe commented Apr 4, 2024

What this PR does / why we need it:

This converts K8sAllowPrivilegeEscalation to use CEL in addition to Rego.

Which issue(s) does this PR fix (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #541

Special notes for your reviewer:

@maxsmythe maxsmythe requested a review from a team as a code owner April 4, 2024 03:48
@maxsmythe maxsmythe marked this pull request as draft April 4, 2024 03:49
JaydipGabani
JaydipGabani previously approved these changes May 16, 2024
@JaydipGabani JaydipGabani self-requested a review May 16, 2024 20:37
@JaydipGabani JaydipGabani dismissed their stale review May 16, 2024 20:38

Approved by mistake

@maxsmythe
Copy link
Contributor Author

bumped minor version

@ritazh
Copy link
Member

ritazh commented Jun 3, 2024

@maxsmythe Just confirming, this PR is ready for review right? not a draft.

Copy link
Contributor

@JaydipGabani JaydipGabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cel LGTM

@maxsmythe
Copy link
Contributor Author

@ritazh Right, no longer a draft, but curious why checks were canceled

@maxsmythe maxsmythe marked this pull request as ready for review June 12, 2024 01:56
@ritazh ritazh changed the title Example of a VAP constraint template: allow-privilege-escalation adding cel for allow-privilege-escalation Jul 5, 2024
Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JaydipGabani JaydipGabani merged commit b68b2a0 into open-policy-agent:master Jul 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CEL code for PSP Policies in library
3 participants