Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CEL to K8sPSPCapabilities template #535

Merged
merged 4 commits into from
Sep 4, 2024

Conversation

maxsmythe
Copy link
Contributor

@maxsmythe maxsmythe commented May 29, 2024

What this PR does / why we need it:

Which issue(s) does this PR fix (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #541

Special notes for your reviewer:

@maxsmythe maxsmythe requested a review from a team as a code owner May 29, 2024 02:35
Copy link
Contributor

@JaydipGabani JaydipGabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CEL looks good to me. We need to update template version and artifact-hub as well. make generate-all will do the job after updating template version. LGTM after these changes

Signed-off-by: Max Smythe <[email protected]>
@maxsmythe
Copy link
Contributor Author

Bumped the minor version

Copy link
Contributor

@JaydipGabani JaydipGabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JaydipGabani
Copy link
Contributor

@maxsmythe should we use snake_case instead of camelCase for naming variables to be more consistent with variables in rego policies?

@maxsmythe
Copy link
Contributor Author

@JaydipGabani

VAP appears to use camel case, and YAML params use camel case, so probably more consistent to stick with camel case.

Example from K8s documentation:

https://kubernetes.io/docs/reference/access-authn-authz/validating-admission-policy/#variable-composition

Copy link

stale bot commented Aug 11, 2024

This issue/PR has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 11, 2024
Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@sozercan sozercan merged commit d59972f into open-policy-agent:master Sep 4, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CEL code for PSP Policies in library
3 participants