chore: adding cel for psp-root-filesystem #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jaydip Gabani <[email protected]>
maxsmythe
requested changes
Jun 5, 2024
| ).map(container, container.name) | ||
| validations: | ||
| - expression: '(has(request.operation) && request.operation == "UPDATE") || size(variables.badContainers) == 0' | ||
| messageExpression: '"only read-only root filesystem container is allowed: " + variabales.badContainers.join(", ")' |
There was a problem hiding this comment.
It seems that CEL was returning with the message for not recognizing the misspelled variable, but gator somehow treated it as violation (which it was expecting for disallow case). And since respective suite.yaml didn't specify expectation of specific message in case of violation, the error didn't get caught in CI.
There was a problem hiding this comment.
I fixed the variable and added verification of violation message in suite.yaml
There was a problem hiding this comment.
If there is an error executing messageExpression, VAP returns a default message instead.
Signed-off-by: Jaydip Gabani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) does this PR fix (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #541
Special notes for your reviewer: