fix: #3146 Support close open/fail for Ready Tracker & surface errors swallowed by grp.Wait() #2237
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
name: benchmark_changes | |
on: | |
issue_comment: | |
types: [created] | |
permissions: | |
contents: read | |
jobs: | |
benchmark: | |
name: "Benchmark" | |
if: github.event.issue.pull_request && github.event.comment.body == '/benchmark' | |
runs-on: ubuntu-22.04 | |
timeout-minutes: 60 | |
permissions: | |
contents: write | |
pull-requests: write | |
steps: | |
- name: Harden Runner | |
uses: step-security/harden-runner@63c24ba6bd7ba022e95695ff85de572c04a18142 # v2.7.0 | |
with: | |
egress-policy: audit | |
- uses: izhangzhihao/delete-comment@98aa1ea5c6304048edf951c20b3114e03c785c79 | |
with: | |
github_token: ${{ secrets.GITHUB_TOKEN }} | |
delete_user_name: github-actions[bot] | |
issue_number: ${{ github.event.issue.number }} | |
- name: Update status | |
uses: peter-evans/create-or-update-comment@71345be0265236311c031f5c7866368bd1eff043 # v4.0.0 | |
with: | |
issue-number: ${{ github.event.issue.number }} | |
body: | | |
[Running benchmark here...](${{ github.server.url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}) | |
- name: Check out base code into the Go module directory | |
uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v3.5.2 | |
with: | |
ref: ${{ github.base_ref }} | |
- name: Run benchmarks on base ref | |
run: make benchmark-test BENCHMARK_FILE_NAME="../base_benchmarks.txt" | |
- name: Check out code into the Go module directory | |
uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v3.5.2 | |
- name: Run benchmark with incoming changes | |
run: make benchmark-test BENCHMARK_FILE_NAME="pr_benchmarks.txt" | |
- name: Compare benchmarks | |
id: get-comment-body | |
run: | | |
export GOPATH="$HOME/go" | |
PATH="$GOPATH/bin:$PATH" | |
go install golang.org/x/perf/cmd/[email protected] | |
benchstat ../base_benchmarks.txt pr_benchmarks.txt > benchstat.txt | |
delimiter=$(openssl rand -hex 8) | |
echo 'msg<<$delimiter' >> $GITHUB_OUTPUT | |
cat benchstat.txt >> $GITHUB_OUTPUT | |
echo '$delimiter' >> $GITHUB_OUTPUT | |
- name: Create commit comment | |
uses: peter-evans/create-or-update-comment@71345be0265236311c031f5c7866368bd1eff043 # v4.0.0 | |
with: | |
issue-number: ${{ github.event.issue.number }} | |
body: | | |
This PR compares its performance to the latest released version. If it performs significantly lower, consider optimizing your changes to improve the performance. | |
``` | |
${{ steps.get-comment-body.outputs.msg }} | |
``` |