Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove finalizer code #3043

Closed
acpana opened this issue Oct 7, 2023 · 3 comments · Fixed by #3085
Closed

refactor: remove finalizer code #3043

acpana opened this issue Oct 7, 2023 · 3 comments · Fixed by #3085

Comments

@acpana
Copy link
Contributor

acpana commented Oct 7, 2023

It sounds like we can remove the controller code that removes the finalizers.

Originally posted by @acpana in #3030 (comment)
@MuneebAijaz
Copy link

hi @acpana , i would like to contribute by starting on small issues like this. Is anyone working on this already?

@acpana acpana mentioned this issue Oct 19, 2023
Merged
@acpana
Copy link
Contributor Author

acpana commented Oct 19, 2023 •
edited
Loading

Oh hey @MuneebAijaz -- thanks for expressing interest; in this case, I had a patch ready already.

Feel free to look for any issues tagged good first issue and those should be good to go if you want to contribute.

https://github.com/open-policy-agent/gatekeeper/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@MuneebAijaz
Copy link

Thank you, will take a look at these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: remove finalizer removal code acpana/gatekeeper
2 participants
@acpana @MuneebAijaz