Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove finalizer removal code #3085

Merged
merged 6 commits into from
Oct 24, 2023
Merged

refactor: remove finalizer removal code #3085

merged 6 commits into from
Oct 24, 2023

Conversation

acpana
Copy link
Contributor

@acpana acpana commented Oct 19, 2023

fixes #3043

@acpana
remove finalizer removal code
e65873f 
Signed-off-by: Alex Pana <[email protected]>

keep comment, mark rbac for removal

Signed-off-by: Alex Pana <[email protected]>
@acpana acpana changed the title remove finalizer removal code refactor: remove finalizer removal code Oct 19, 2023
@acpana acpana mentioned this pull request Oct 19, 2023
Open
@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c5798c9) 52.45% compared to head (3fed229) 52.59%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3085      +/-   ##
==========================================
+ Coverage   52.45%   52.59%   +0.13%     
==========================================
  Files         134      134              
  Lines       11955    11886      -69     
==========================================
- Hits         6271     6251      -20     
+ Misses       5192     5147      -45     
+ Partials      492      488       -4
Flag Coverage Δ
unittests 52.59% <ø> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/controller/config/config_controller.go 53.57% <ø> (-6.81%) ⬇️
pkg/controller/constraint/constraint_controller.go 6.18% <ø> (+0.45%) ⬆️
...onstrainttemplate/constrainttemplate_controller.go 62.40% <ø> (+2.78%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acpana acpana requested a review from maxsmythe October 19, 2023 23:51
maxsmythe
maxsmythe approved these changes Oct 21, 2023
View reviewed changes
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@acpana acpana requested review from sozercan and ritazh October 23, 2023 17:54
sozercan
sozercan approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@acpana acpana requested a review from a team as a code owner October 24, 2023 17:25
@acpana acpana merged commit f905e30 into open-policy-agent:master Oct 24, 2023
14 checks passed
Mattes83 pushed a commit to Mattes83/gatekeeper that referenced this pull request Oct 25, 2023
@acpana @sozercan @Mattes83
refactor: remove finalizer removal code (open-policy-agent#3085)
b18dde9 
Signed-off-by: Alex Pana <[email protected]>
Signed-off-by: Sertaç Özercan <[email protected]>
Signed-off-by: alex <[email protected]>
Co-authored-by: Sertaç Özercan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxsmythe maxsmythe maxsmythe approved these changes

@sozercan sozercan sozercan approved these changes

@ritazh ritazh Awaiting requested review from ritazh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor: remove finalizer code
4 participants
@acpana @codecov-commenter @sozercan @maxsmythe