-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add docs for cel based Validating Admission Policy support #2960
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Do we want to mention users need to install the dev version of G8r for this to work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added minor comments, LGTM otherwise
I just realized in the other readme, we are pointing to https://open-policy-agent.github.io/gatekeeper/website/docs/install/#deploying-a-release-using-development-image instead of nvm the link points to the same content. |
Signed-off-by: Rita Zhang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…n-policy-agent#2960) Signed-off-by: Rita Zhang <[email protected]>
…n-policy-agent#2960) Signed-off-by: Rita Zhang <[email protected]>
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #2947
Special notes for your reviewer: