Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add docs for cel based Validating Admission Policy support #2960

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

ritazh
Copy link
Member

@ritazh ritazh commented Aug 18, 2023

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #2947

Special notes for your reviewer:

website/docs/validating-admission-policy Show resolved Hide resolved
website/docs/validating-admission-policy Outdated Show resolved Hide resolved
website/docs/validating-admission-policy Outdated Show resolved Hide resolved
website/docs/validating-admission-policy Outdated Show resolved Hide resolved
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Do we want to mention users need to install the dev version of G8r for this to work?

website/docs/validating-admission-policy Outdated Show resolved Hide resolved
Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added minor comments, LGTM otherwise

@ritazh
Copy link
Member Author

ritazh commented Aug 18, 2023

Looks great! Do we want to mention users need to install the dev version of G8r for this to work?

I just realized in the other readme, we are pointing to https://open-policy-agent.github.io/gatekeeper/website/docs/install/#deploying-a-release-using-development-image instead of docker pull openpolicyagent/gatekeeper:dev which is built off the latest commit. do you care if I update to the docker image everywhere?

nvm the link points to the same content.

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ritazh ritazh merged commit 46035e8 into open-policy-agent:master Aug 18, 2023
@ritazh ritazh deleted the doc-vap branch August 18, 2023 01:42
salaxander pushed a commit to salaxander/gatekeeper that referenced this pull request Sep 13, 2023
Mattes83 pushed a commit to Mattes83/gatekeeper that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc: Add k8s cel documentations
3 participants