Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support DELETE configs validation #3089

Merged
merged 4 commits into from
Oct 25, 2023

Conversation

acpana
Copy link
Contributor

@acpana acpana commented Oct 19, 2023

fixes #3058

@acpana acpana requested a review from maxsmythe October 19, 2023 22:39
pkg/webhook/policy.go Outdated Show resolved Hide resolved
@acpana acpana requested a review from maxsmythe October 23, 2023 18:29
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acpana acpana requested a review from a team as a code owner October 24, 2023 17:25
@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (f905e30) 52.51% compared to head (cb75ed9) 52.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3089      +/-   ##
==========================================
+ Coverage   52.51%   52.66%   +0.15%     
==========================================
  Files         134      134              
  Lines       11886    11890       +4     
==========================================
+ Hits         6242     6262      +20     
+ Misses       5154     5141      -13     
+ Partials      490      487       -3     
Flag Coverage Δ
unittests 52.66% <66.66%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/webhook/policy.go 34.81% <66.66%> (+1.34%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for fixing this!

@acpana acpana merged commit 0019b52 into open-policy-agent:master Oct 25, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to delete config resource due to built-in Gatekeeper policy validator
4 participants