chore: adding default helm values for pubsub audit connection and channel #3097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jaydip Gabani <[email protected]>
sozercan
reviewed
Oct 23, 2023
sozercan
reviewed
Oct 23, 2023
sozercan
reviewed
Oct 23, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3097 +/- ##
=======================================
Coverage 52.67% 52.67%
=======================================
Files 134 134
Lines 11890 11890
=======================================
Hits 6263 6263
Misses 5140 5140
Partials 487 487
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
sozercan
reviewed
Oct 23, 2023
sozercan
reviewed
Oct 23, 2023
Signed-off-by: Jaydip Gabani <[email protected]>
sozercan
reviewed
Oct 24, 2023
Signed-off-by: Jaydipkumar Arvindbhai Gabani <[email protected]>
Signed-off-by: Jaydip Gabani <[email protected]>
Signed-off-by: Jaydipkumar Arvindbhai Gabani <[email protected]>
sozercan
reviewed
Oct 25, 2023
Signed-off-by: Jaydipkumar Arvindbhai Gabani <[email protected]>
Signed-off-by: Jaydip Gabani <[email protected]>
sozercan
reviewed
Oct 25, 2023
Signed-off-by: Jaydip Gabani <[email protected]>
Signed-off-by: Jaydipkumar Arvindbhai Gabani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: adding default helm values and updating documentation to make it more accurate.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: