Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: auto signing PR for dco #3120

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Conversation

JaydipGabani
Copy link
Contributor

What this PR does / why we need it: Sign off PRs raised by release pr action to eliminate the need of manually signing it for DCO.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #3036

Special notes for your reviewer:

Signed-off-by: Jaydip Gabani <[email protected]>
@JaydipGabani JaydipGabani requested a review from a team as a code owner October 27, 2023 20:10
@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3a83700) 52.70% compared to head (7f9287a) 52.53%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3120      +/-   ##
==========================================
- Coverage   52.70%   52.53%   -0.18%     
==========================================
  Files         134      134              
  Lines       11890    11890              
==========================================
- Hits         6267     6246      -21     
- Misses       5138     5153      +15     
- Partials      485      491       +6     
Flag Coverage Δ
unittests 52.53% <ø> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sozercan
Copy link
Member

@JaydipGabani this is awesome! were you able to test this in your fork?

Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending testing confirmation

@JaydipGabani
Copy link
Contributor Author

@sozercan Yes! I was able to test this on my fork. I don't have DCO rule set, but PR raised by the action has signoff msg attached to the commit. This is the commit done by the action.

@sozercan sozercan merged commit 40f15ef into open-policy-agent:master Oct 27, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Signoff release PRs through GH action
4 participants