Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search popups for buildings only #407

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Search popups for buildings only #407

merged 2 commits into from
Jan 17, 2025

Conversation

khdlr
Copy link
Member

@khdlr khdlr commented Jan 17, 2025

This changes some small things in the search box behaviour to reduce possible confusion from the search results.

  1. The map will always zoom to the bounding box of the search result (previously it would zoom in to zoom level 17, centering on the search result's midpoint, which can be confusing when the search result is not a building, but e.g. an entire city or road)
  2. The "simulation" popup will only show if the search result is actually a building. It will no longer show weird random popups for larger objects such as ", Berlin"

This should fix issues such as the one error report we got via email.

@khdlr khdlr requested a review from FlorianK13 January 17, 2025 11:08
@khdlr khdlr merged commit a3e7cf8 into main Jan 17, 2025
2 checks passed
@FlorianK13 FlorianK13 deleted the feature/search_boundary_zoom branch January 17, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants