Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triangulate Vegetation #410

Merged
merged 8 commits into from
Jan 24, 2025
Merged

Triangulate Vegetation #410

merged 8 commits into from
Jan 24, 2025

Conversation

khdlr
Copy link
Member

@khdlr khdlr commented Jan 21, 2025

This PR greatly reduces the number of shading triangles by meshing the vegetation height map instead of the current "blocks" approach. This speeds up the simulation quite a bit for areas with lots of vegetation.

Experimental Triangle Counts

Site #Shading triangles previously #Shading triangles after change
Lange Point (https://www.openpv.de/simulation/11.718/48.406) 15168 3069
TUM Main Campus (https://www.openpv.de/simulation/11.567/48.148) 3855 2990
Somewhere in Bayerischer Wald (https://openpv.de/simulation/13.305/49.064) 16040 3028

Visuals

Before:

Screenshot_20250121_131813

After:

Screenshot_20250121_131818

@khdlr khdlr requested a review from FlorianK13 January 21, 2025 12:25
@khdlr khdlr mentioned this pull request Jan 21, 2025
@khdlr khdlr requested a review from MartGro January 21, 2025 12:29
@khdlr khdlr merged commit bfc86ce into main Jan 24, 2025
2 checks passed
@khdlr khdlr deleted the feature/triangulate_vegetation branch January 24, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants