Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable 3rf's default tone mapping #414

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Disable 3rf's default tone mapping #414

merged 2 commits into from
Jan 24, 2025

Conversation

khdlr
Copy link
Member

@khdlr khdlr commented Jan 24, 2025

By default, react-three-fiber applies some tone mapping to the scene, causing our terrain map textures to look too bright and washed out. This PR fixes that by disabling the tone mapping.

TODO:

  • This also affects the visuals of the rendered buildings. Should we adjust the building / simulation colours? I'd consider making the non-simulation buildings (beige ones) a bit brighter/less saturated.

Map view

image

3D view on main

image

3D view after this PR

image

@FlorianK13
Copy link
Member

Yes, I also think less saturated looks better.

@khdlr khdlr merged commit e4b7d90 into main Jan 24, 2025
2 checks passed
@khdlr khdlr deleted the feature/disable_tonemapping branch January 24, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants