Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hammer/better labels #841

Merged
merged 4 commits into from
Nov 28, 2023
Merged

Hammer/better labels #841

merged 4 commits into from
Nov 28, 2023

Conversation

aaronchongth
Copy link
Member

What's new

  • Default settings, no labels anywhere except during hover, only show pickup/dropoff waypoints
  • Combined lift and door icons
  • Only able to toggle door labels
  • Turn off robot labels by default
  • Allow hover over robot icons

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: 268 lines in your changes are missing coverage. Please review.

Comparison is base (fe0e808) 49.35% compared to head (10878b2) 48.72%.
Report is 21 commits behind head on deploy/hammer.

Files Patch % Lines
packages/dashboard/src/components/map-app.tsx 0.00% 103 Missing ⚠️
.../dashboard/src/components/delivery-alert-store.tsx 0.00% 61 Missing ⚠️
...s/dashboard/src/components/tasks/task-schedule.tsx 0.00% 25 Missing ⚠️
...shboard/src/components/three-fiber/robot-three.tsx 0.00% 11 Missing ⚠️
...ashboard/src/components/three-fiber/lift-three.tsx 0.00% 10 Missing ⚠️
...react-components/lib/lifts/lift-table-datagrid.tsx 10.00% 1 Missing and 8 partials ⚠️
...react-components/lib/doors/door-table-datagrid.tsx 11.11% 0 Missing and 8 partials ⚠️
...mponents/lib/map/three-fiber/robot-three-maker.tsx 38.46% 4 Missing and 4 partials ⚠️
...kages/dashboard/src/components/tasks/tasks-app.tsx 0.00% 7 Missing ⚠️
...oard/src/components/three-fiber/camera-control.tsx 0.00% 5 Missing ⚠️
... and 8 more
Additional details and impacted files
@@                Coverage Diff                @@
##           deploy/hammer     #841      +/-   ##
=================================================
- Coverage          49.35%   48.72%   -0.64%     
=================================================
  Files                285      285              
  Lines               7564     7699     +135     
  Branches            1050     1137      +87     
=================================================
+ Hits                3733     3751      +18     
- Misses              3682     3773      +91     
- Partials             149      175      +26     
Flag Coverage Δ
dashboard 15.19% <9.05%> (+0.12%) ⬆️
react-components 47.57% <22.91%> (-0.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Aaron Chong <[email protected]>
@aaronchongth aaronchongth changed the title Hamer/better labels Hammer/better labels Nov 27, 2023
Copy link
Collaborator

@Angatupyry Angatupyry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it and it works well!
Thanks, Aaron!

LGTM!

@aaronchongth aaronchongth merged commit 2620942 into deploy/hammer Nov 28, 2023
@aaronchongth aaronchongth deleted the hamer/better-labels branch November 28, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants