Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create task form - Adapting styles according to resolution #853

Merged
merged 4 commits into from
Dec 1, 2023

Conversation

Angatupyry
Copy link
Collaborator

What's new

  • Decrease font size as the screen gets smaller

image

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Discussion

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 701 lines in your changes are missing coverage. Please review.

Comparison is base (fe0e808) 49.35% compared to head (a8a841b) 26.93%.
Report is 32 commits behind head on deploy/hammer.

Files Patch % Lines
packages/dashboard/src/components/map-app.tsx 0.00% 171 Missing ⚠️
...ackages/react-components/lib/tasks/create-task.tsx 0.00% 68 Missing ⚠️
.../dashboard/src/components/delivery-alert-store.tsx 0.00% 61 Missing ⚠️
packages/react-components/lib/tasks/utils.ts 4.76% 54 Missing and 6 partials ⚠️
packages/dashboard/src/components/door-summary.tsx 0.00% 51 Missing ⚠️
packages/dashboard/src/components/lift-summary.tsx 0.00% 50 Missing ⚠️
...kages/dashboard/src/components/tasks/tasks-app.tsx 0.00% 41 Missing ⚠️
...shboard/src/components/tasks/task-cancellation.tsx 0.00% 37 Missing ⚠️
...s/dashboard/src/components/tasks/task-schedule.tsx 0.00% 28 Missing ⚠️
...ashboard/src/components/three-fiber/lift-three.tsx 0.00% 12 Missing ⚠️
... and 23 more
Additional details and impacted files
@@                Coverage Diff                 @@
##           deploy/hammer     #853       +/-   ##
==================================================
- Coverage          49.35%   26.93%   -22.42%     
==================================================
  Files                285      157      -128     
  Lines               7564     5168     -2396     
  Branches            1050     1287      +237     
==================================================
- Hits                3733     1392     -2341     
+ Misses              3682     3592       -90     
- Partials             149      184       +35     
Flag Coverage Δ
api-server ?
dashboard 14.02% <4.22%> (-1.05%) ⬇️
react-components 44.53% <14.69%> (-3.55%) ⬇️
rmf-auth ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@aaronchongth aaronchongth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great, thanks Cesar! I'm gonna commit directly for a tiny fix on the max width.

@aaronchongth aaronchongth merged commit 9a5259f into deploy/hammer Dec 1, 2023
@aaronchongth aaronchongth deleted the hammer/dialog-resolution branch December 1, 2023 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants