Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hammer/frontend changes #856

Merged
merged 15 commits into from
Dec 4, 2023
Merged

Conversation

aaronchongth
Copy link
Member

@aaronchongth aaronchongth commented Dec 1, 2023

What's new

  • Various front-end tweaks, mostly in low resolution
  • Added a console log for checking what causes delivery alerts to not be cancellable
  • Refactored task cancellation buttons to be their own component
  • Task cancellation confirmation dialog
  • Fixed robot icon scaling within a nested mesh component

image

icons before fix
image

icons after fix
image

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 767 lines in your changes are missing coverage. Please review.

Comparison is base (fe0e808) 49.35% compared to head (32e7a17) 26.77%.
Report is 37 commits behind head on deploy/hammer.

Files Patch % Lines
packages/dashboard/src/components/map-app.tsx 0.00% 171 Missing ⚠️
.../dashboard/src/components/delivery-alert-store.tsx 0.00% 94 Missing ⚠️
...ackages/react-components/lib/tasks/create-task.tsx 0.00% 68 Missing ⚠️
packages/react-components/lib/tasks/utils.ts 4.76% 54 Missing and 6 partials ⚠️
packages/dashboard/src/components/door-summary.tsx 0.00% 51 Missing ⚠️
packages/dashboard/src/components/lift-summary.tsx 0.00% 50 Missing ⚠️
...shboard/src/components/tasks/task-cancellation.tsx 0.00% 48 Missing ⚠️
...kages/dashboard/src/components/tasks/tasks-app.tsx 0.00% 47 Missing ⚠️
...s/dashboard/src/components/tasks/task-schedule.tsx 0.00% 28 Missing ⚠️
packages/react-components/lib/alert-dialog.tsx 6.66% 2 Missing and 12 partials ⚠️
... and 25 more
Additional details and impacted files
@@                Coverage Diff                 @@
##           deploy/hammer     #856       +/-   ##
==================================================
- Coverage          49.35%   26.77%   -22.58%     
==================================================
  Files                285      157      -128     
  Lines               7564     5202     -2362     
  Branches            1050     1331      +281     
==================================================
- Hits                3733     1393     -2340     
+ Misses              3682     3611       -71     
- Partials             149      198       +49     
Flag Coverage Δ
api-server ?
react-components 44.21% <15.87%> (-3.86%) ⬇️
rmf-auth ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aaronchongth aaronchongth merged commit dce245b into deploy/hammer Dec 4, 2023
3 of 4 checks passed
@aaronchongth aaronchongth deleted the hammer/frontend-changes branch December 4, 2023 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant