Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change S0 calculation to enforce Again < Hard < Good < Easy.py #132

Closed
wants to merge 2 commits into from

Conversation

Expertium
Copy link
Contributor

Relevant comment: ankitects/anki#3367 (comment)

These changes will prevent situations where Again = Hard, or Hard = Good, or anything like that. But we still need to do something about the other problem. Read my comment above.

@L-M-Sherlock
Copy link
Member

L-M-Sherlock commented Aug 24, 2024

This change may induce a problem: if the initial stability of again is very large (perhaps due to the lack of data, the user rarely presses again in the first learning), the initial stabilities of hard, good and easy will be enforced correctly.

The problem you want to solve has been resolved in open-spaced-repetition/fsrs-rs#212

@Expertium
Copy link
Contributor Author

Expertium commented Aug 24, 2024

Can you at least keep the clampings I proposed?
Also, smooth_and_fill isn't strict enough. We need Again < Hard < Good < Easy, not just Again <= Hard <= Good <= Easy

@L-M-Sherlock
Copy link
Member

I mean the clamps can induce the problem. So I cannot keep it.

@Expertium
Copy link
Contributor Author

Alright, close this PR, but please come up with a way to enforce strict monotonicty, aka "less than", not "less than or equal to"

@L-M-Sherlock
Copy link
Member

OK, I will consider it. Could you open a new issue to record this feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants