Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor tweaks to #166 #167

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Minor tweaks to #166 #167

merged 1 commit into from
Mar 11, 2024

Conversation

dae
Copy link
Collaborator

@dae dae commented Mar 11, 2024

  • Avoid par_iter() inside existing into_par_iter()
  • Avoid extra trainset clone

@dae
Minor tweaks to #166
2426871 
- Avoid par_iter() inside existing into_par_iter()
- Avoid extra trainset clone
L-M-Sherlock
L-M-Sherlock approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@L-M-Sherlock L-M-Sherlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@L-M-Sherlock L-M-Sherlock merged commit e872114 into main Mar 11, 2024
3 checks passed
@L-M-Sherlock L-M-Sherlock deleted the tweaks branch March 11, 2024 03:35
@L-M-Sherlock L-M-Sherlock mentioned this pull request Mar 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@L-M-Sherlock L-M-Sherlock L-M-Sherlock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dae @L-M-Sherlock