Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/filter rating_stability to match rating_count keys #225

Merged

Conversation

L-M-Sherlock
Copy link
Member

Prevents processing non-existent rating data, improving data consistency and avoiding potential errors when working with unmatched ratings.

Source: https://forums.ankiweb.net/t/anki-24-10-beta/49989/51?u=l.m.sherlock

Error:

[/Users/jarrettye/Codes/open-spaced-repetition/fsrs-rs/src/pre_training.rs:171:5] &rating_stability = {
    2: 0.9449276,
    1: 0.057034113,
    4: 0.7255576,
    3: 1.1028688,
}
[/Users/jarrettye/Codes/open-spaced-repetition/fsrs-rs/src/pre_training.rs:172:5] &rating_count = {
    2: 303,
    3: 567,
}
thread '<unnamed>' panicked at /Users/jarrettye/Codes/open-spaced-repetition/fsrs-rs/src/pre_training.rs:179:62:
no entry found for key

Prevents processing non-existent rating data, improving data consistency and avoiding potential errors when working with unmatched ratings.
@L-M-Sherlock L-M-Sherlock merged commit a5701f0 into main Sep 29, 2024
3 checks passed
@L-M-Sherlock L-M-Sherlock deleted the Fix/filter-rating_stability-to-match-rating_count-keys branch September 29, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants