Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R_MIN = 0.70 #229

Merged
merged 2 commits into from
Oct 4, 2024
Merged

R_MIN = 0.70 #229

merged 2 commits into from
Oct 4, 2024

Conversation

Expertium
Copy link
Contributor

I have tried the most recent beta: https://github.com/ankitects/anki/releases/tag/24.10beta2

CMRR values have gone down for every single one of my presets, meaning that the old values were overestimates. Out of 7 presets that I tried CMRR on, I got 0.75 for three of them, and 0.90 for only one of them.

@user1823, @brishtibheja I'd like you to optimize your parameters and try CMRR in Anki 24.10 beta 2. If your CMRR values are also only going down and not up, then it would imply that the range needs to be extended towards lower values.

I have tried the most recent beta: https://github.com/ankitects/anki/releases/tag/24.10beta2

CMRR values have gone done for every single one of my presets, meaning that the old values were overestimates. Also, out of 7 presets that I tried CMRR on, I got 0.75 for three of them, and 0.90 for only one of them.

@user1823, @brishtibheja I'd like you to optimize your parameters and try CMRR in Anki 24.10 beta 2. If your CMRR values are also only going down, then it would imply that the range needs to be extended.
@user1823
Copy link
Contributor

user1823 commented Oct 4, 2024

For me, MRR decreased from 0.87 to 0.75.

But, before extending the range, we should try to find the reason why the value is going down. Is there any logical explanation? Or do we have a bug?

@Expertium
Copy link
Contributor Author

Expertium commented Oct 4, 2024

Good question.
Here's the old workload/retention graph:
image

New one:
image

It's hard to compare them because the old one doesn't have text that says "minimum workload x(value)", but basically in the old one it's x1, x2, x3, x4. The new graph suggests that previously we overestimated how quickly workload increases as retention increases. The new graph is less steep. However, this doesn't automatically mean that the minimum has shifted, unless I'm bad at math. So idk.
EDIT: previously, the workload at lower retentions was underestimated since FSRS didn't consider time spent on same-day reviews. If the workload was underestimated, it would make sense for the minimum to shift towards higher retention than towards lower retention. Hm. Yeah, idk what's going on.

Copy link
Member

@L-M-Sherlock L-M-Sherlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@L-M-Sherlock L-M-Sherlock merged commit f624c99 into open-spaced-repetition:main Oct 4, 2024
3 checks passed
@Expertium
Copy link
Contributor Author

We should've probably discussed it a bit more...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants