Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/sort FSRSItem by length to speed up training #32

Merged
merged 14 commits into from
Aug 28, 2023
Merged

Feat/sort FSRSItem by length to speed up training #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
c1143c1
sort FSRSItem by length to speed up training
L-M-Sherlock Aug 25, 2023
de573a4
correct shape of logits
L-M-Sherlock Aug 25, 2023
19dc7b5
cargo fmt
L-M-Sherlock Aug 25, 2023
790d5c3
Create batches with random seq_len
dae Aug 26, 2023
48191f9
implement BatchShuffledDataset
L-M-Sherlock Aug 26, 2023
c2e86cf
cargo fmt
L-M-Sherlock Aug 26, 2023
61c798d
rename batch_shuffle & add English comments
L-M-Sherlock Aug 26, 2023
bebedb9
Use an SQL sort and .group_by() for separating by card id
dae Aug 26, 2023
a34f5e4
We don't need InMemDataset
dae Aug 26, 2023
b6b0604
Move all tests into test modules
dae Aug 27, 2023
9f978ec
Remove redundant test_ prefix/suffix
dae Aug 27, 2023
a955aeb
Apply cosine_annealing patch from Asuka to fix test
dae Aug 27, 2023
c45aab4
Run tests in CI, except training
dae Aug 27, 2023
d6c71f6
Limit checks to pull requests; bust cache
dae Aug 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/check.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,9 @@ cargo fmt --check || (
)

cargo clippy -- -Dwarnings

install -d tests/data/
pushd tests/data/
wget https://github.com/open-spaced-repetition/fsrs-optimizer-burn/files/12394182/collection.anki21.zip
unzip *.zip
SKIP_TRAINING=1 cargo test
5 changes: 2 additions & 3 deletions .github/workflows/check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
name: Check code
on:
push:
pull_request:

jobs:
Expand All @@ -16,9 +15,9 @@ jobs:
~/.cargo/registry
~/.cargo/git
target
key: ${{ runner.os }}-rust-release-v5-${{ hashFiles('Cargo.lock') }}
key: ${{ runner.os }}-rust-release-v6-${{ hashFiles('Cargo.lock') }}
restore-keys: |
${{ runner.os }}-rust-release-v5
${{ runner.os }}-rust-release-v6
${{ runner.os }}-rust-release

- name: Run checks
Expand Down
105 changes: 53 additions & 52 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,4 @@ rusqlite = { version = "0.29.0" }
chrono = "0.4.26"
chrono-tz = "0.8.3"
itertools = "0.11.0"
rand = "0.8.5"
Loading