Skip to content

Commit

Permalink
Remove unnecessary recommendation about service.name (#135)
Browse files Browse the repository at this point in the history
Contributes to #131

service.name is an existing OpenTelemetry convention. OpAMP is not in the
business of defining OpenTelemetry's semantic conventions. I deleted the
unnecessary wording that tried to add more meaning to the service.name
that is not our business to do.
  • Loading branch information
tigrannajaryan authored Oct 17, 2022
1 parent 1523683 commit aaace74
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions specification.md
Original file line number Diff line number Diff line change
Expand Up @@ -948,8 +948,7 @@ https://github.com/open-telemetry/opentelemetry-specification/tree/main/specific
For standalone running Agents (such as OpenTelemetry Collector) the following
attributes SHOULD be specified:

- service.name should be set to a reverse FQDN that uniquely identifies the
Agent type, e.g. "io.opentelemetry.collector"
- service.name should be set to the same value that the Agent uses in its own telemetry.
- service.namespace if it is used in the environment where the Agent runs.
- service.version should be set to version number of the Agent build.
- service.instance.id should be set. It may be be set equal to the Agent's
Expand Down

0 comments on commit aaace74

Please sign in to comment.