Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add message about available components to AgentDetails #201
Add message about available components to AgentDetails #201
Changes from 1 commit
c5aa281
2aec202
4fbdc8c
1cfdaef
a800b8f
da590b2
96733ae
d84d87b
2556d26
0abd35a
185c8a2
4d3af71
a2ca5a1
32a70a5
ed37d51
8089174
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ID here works for how everything is structured in contrib. I'm wondering if you could cause a collision through, simply by having multiple components in one module? Do we need to support that? I don't think the builder supports that case currently, either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically the builder does support this, though I don't think it's frequently used. If components are hosted under different paths inside the same module, the builder can be told to include a component per package. That is, if the module is
github.com/open-telemetry/opentelemetry-collector-contrib
, the path could bereceiver/hostmetricsreceiver
orprocessor/transform
for the package within the module where the component is found. I think it's safe to say that these could be reported asgithub.com/open-telemetry/opentelemetry-collector-contrib/[...]@vX.Y.Z
, though I'm not sure how this is currently handled in the Collector's reporting of each module.If that's accounted for, the builder limits each path/package to a single component, so we're okay from that perspective.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good point.
I inverted the ID to be the type string instead; I think the type should be unique within it's class (e.g. there is only one "hostmetricsreceiver" in any given build of the agent). Then the module is in the metadata as extra information to identify the exact version of code.