refactor: capabilities to protobufs.AgentCapabilities

extension/opampextension/config.go

@@ -7,6 +7,7 @@ import (
 	"errors"
 
 	"github.com/oklog/ulid/v2"
+	"github.com/open-telemetry/opamp-go/protobufs"
 	"go.opentelemetry.io/collector/config/configopaque"
 	"go.opentelemetry.io/collector/config/configtls"
 )
@@ -29,6 +30,17 @@ type Capabilities struct {
 	ReportsEffectiveConfig bool `mapstructure:"reports_effective_config"`
 }
 
+func (caps Capabilities) toAgentCapabilities() protobufs.AgentCapabilities {
+	// All Agents MUST report status.
+	agentCapabilities := protobufs.AgentCapabilities_AgentCapabilities_ReportsStatus
+
+	if caps.ReportsEffectiveConfig {
+		agentCapabilities |= protobufs.AgentCapabilities_AgentCapabilities_ReportsEffectiveConfig
+	}
+
+	return agentCapabilities
+}
+
 // OpAMPServer contains the OpAMP transport configuration.
 type OpAMPServer struct {
 	WS *OpAMPWebsocket `mapstructure:"ws"`

extension/opampextension/opamp_agent.go

@@ -76,11 +76,7 @@ func (o *opampAgent) Start(_ context.Context, _ component.Host) error {
 			},
 			OnMessageFunc: o.onMessage,
 		},
-		Capabilities: protobufs.AgentCapabilities_AgentCapabilities_ReportsStatus,
-	}
-
-	if o.capabilities.ReportsEffectiveConfig {
-		settings.Capabilities |= protobufs.AgentCapabilities_AgentCapabilities_ReportsEffectiveConfig
+		Capabilities: o.capabilities.toAgentCapabilities(),
 	}
 
 	if err := o.createAgentDescription(); err != nil {