Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate creating issues for failing tests on main #36761

Open
mx-psi opened this issue Dec 10, 2024 · 3 comments
Open

Automate creating issues for failing tests on main #36761

mx-psi opened this issue Dec 10, 2024 · 3 comments
Labels
ci-cd CI, CD, testing, build issues help wanted Extra attention is needed priority:p2 Medium

Comments

@mx-psi
Copy link
Member

mx-psi commented Dec 10, 2024

Component(s)

No response

Describe the issue you're reporting

We have a bunch of tests that fail on main and are not getting enough attention. We should automate creating an issue (see e.g. here) on failing tests on main. Ideally it should contain:

  • What test is failing
  • On what commit it is failing
  • (Optional) Ideally logs/a link to the logs?
  • (Optional) A diff for skipping the test, or even a PR?

The workflow should check if an issue already exists (and leave a comment on the existing issue if not?)

Information about failing unit tests can be retrieved via the JSON output of gotestsum.

@mx-psi mx-psi added help wanted Extra attention is needed priority:p2 Medium ci-cd CI, CD, testing, build issues labels Dec 10, 2024
@mowies
Copy link
Member

mowies commented Dec 10, 2024

This could get pretty spammy. If there's good way to prevent that, I would be for something like that.

@mx-psi
Copy link
Member Author

mx-psi commented Dec 10, 2024

This could get pretty spammy. If there's good way to prevent that, I would be for something like that.

Is the spamminess about the total number of issues (i.e. the total number of tests failing)? Or about each issue getting a lot of comments?

Instead of comments we could just edit the issue body and add a new line for each commit in which a test fails (that would avoid some notifications).

One thing I like is that the spam is proportional to the number of things that are broken, so if somebody wants less spam, they know what to do 😅 but I agree we don't want too much spam

@mowies
Copy link
Member

mowies commented Dec 16, 2024

One thing I like is that the spam is proportional to the number of things that are broken, so if somebody wants less spam, they know what to do 😅 but I agree we don't want too much spam

That's one way to look at it, yeah 😄

No, I mean I just expressed my concern. There's definitely a good way of solving this without being too spammy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd CI, CD, testing, build issues help wanted Extra attention is needed priority:p2 Medium
Projects
None yet
Development

No branches or pull requests

2 participants